Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: enable non-prep plan cache by default on Master #43904

Merged
merged 1 commit into from
May 17, 2023

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented May 17, 2023

What problem does this PR solve?

Issue Number: ref #36598

Problem Summary: planner: enable non-prep plan cache by default on Master

What is changed and how it works?

planner: enable non-prep plan cache by default on Master

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@qw4990 qw4990 requested a review from a team as a code owner May 17, 2023 06:30
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 17, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • xuyifangreeneyes

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 17, 2023
@qw4990
Copy link
Contributor Author

qw4990 commented May 17, 2023

/test mysql-test

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 17, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 17, 2023
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133
Copy link
Member

bb7133 commented May 17, 2023

/merge

1 similar comment
@qw4990
Copy link
Contributor Author

qw4990 commented May 17, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 17, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 934ce9d

1 similar comment
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 17, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 934ce9d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic/plan-cache release-note-none sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants