Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor, planner: fix indexLookUp with static pruning #44139

Merged
merged 10 commits into from May 25, 2023
Merged

executor, planner: fix indexLookUp with static pruning #44139

merged 10 commits into from May 25, 2023

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented May 24, 2023 •
edited

What problem does this PR solve?

Issue Number: close #44123

Problem Summary: The root case is we asked one more column which is model.ExtraPhysTblID in indexReq. When resp.EncodeType = EncodeType_TypeDefault, it can't handle it correctly.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 24, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none needs-cherry-pick-release-7.1 size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 24, 2023
bb7133
bb7133 approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 24, 2023
hawkingrei
hawkingrei reviewed May 25, 2023
View reviewed changes
executor/builder.go Outdated
@@ -3882,6 +3882,21 @@ func buildIndexReq(ctx sessionctx.Context, columns []*model.IndexColumn, handleL
return indexReq, err
}

func needExtraCol(is *plannercore.PhysicalIndexScan) bool {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be a member function of plannercore.PhysicalIndexScan.

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 25, 2023
@Defined2014
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 25, 2023

This pull request has been accepted and is ready to merge.

Commit hash: d49be78

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 25, 2023
@Defined2014
Copy link
Contributor Author

/retest

@Defined2014
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit f944c6d into pingcap:master May 25, 2023
8 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #44170.

@ti-chi-bot ti-chi-bot mentioned this pull request May 25, 2023
Closed
12 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 25, 2023
@Defined2014 @ti-chi-bot
This is an automated cherry-pick of pingcap#44139
9c9cc9d 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@Defined2014 Defined2014 deleted the fix-44123 branch May 25, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@xhebox xhebox xhebox approved these changes

@winoros winoros Awaiting requested review from winoros

@guo-shaoge guo-shaoge Awaiting requested review from guo-shaoge

@mjonss mjonss Awaiting requested review from mjonss

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
needs-cherry-pick-release-7.1 release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

data inconsistency is reported when query with for update clause
5 participants
@Defined2014 @hawkingrei @ti-chi-bot @bb7133 @xhebox