*: Fix a bug when have a lot of jobs in upgrading state(#44162) #44172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
release-note-none
size/M
zimulala
added
do-not-merge/work-in-progress
|
LGTM |
zimulala
removed
the
do-not-merge/work-in-progress
ti-chi-bot
bot
added
the
size/L
zimulala
changed the title
zimulala
force-pushed
the
zimuxia/7.1-fix-bug
branch
from
6e2dcfd
to
88930ec
Compare
tangenta
approved these changes
May 25, 2023
zimulala
added
type/cherry-pick-for-release-7.1
and removed
status/LGT1
VelocityLight
added
cherry-pick-approved
zimulala
force-pushed
the
zimuxia/7.1-fix-bug
branch
from
88930ec
to
2ddb8d8
Compare
XuHuaiyu
approved these changes
May 25, 2023
ti-chi-bot
bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 2ddb8d8
|
ti-chi-bot
bot
added
the
status/can-merge
zimulala
added
the
do-not-merge/hold
|
/merge |
zimulala
removed
the
do-not-merge/hold
VelocityLight
added
do-not-merge/cherry-pick-not-approved
cherry-pick-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #44159
Problem Summary:
What is changed and how it works?
When we into the upgrading state we can do the
CannotPauseDDLJobjobs.Check List
Tests
As slowly pause user ddl will let tidb upgrade failed #44159
deploy a cluster add do large ddl in queueing
upgrade the cluster
Before this PR, can't upgrade successfully
After this PR, can upgrade successfully
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.