Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: add idx_create_time for stats_meta_history and stats_history (#44195) #44201

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #44195

What problem does this PR solve?

Issue Number: close #44169

Problem Summary:

What is changed and how it works?

  1. Add index idx_create_time(create_time) for both mysql.stats_meta_history and mysql.stats_history. With the index, SELECT and DELETE statements of stats history GC would be more efficient.
  2. Reserve some bootstrap version slots(147-166) for patches for v7.1.x. Just the same thing as session: fix upgrade #40182 did.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Create a table. Do insert and analyze several times.

set @@global.tidb_historical_stats_duration=1s;

Observe GCStats SQLs on dashboard.
Screenshot 2023-05-26 at 01 27 06
Screenshot 2023-05-26 at 01 26 45
Screenshot 2023-05-26 at 01 27 32

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot requested a review from a team as a code owner May 26, 2023 02:56
@ti-chi-bot ti-chi-bot added release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 labels May 26, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 26, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 26, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 26, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 26, 2023
@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 26, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 4e16632

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 26, 2023
@ti-chi-bot ti-chi-bot bot merged commit f8f6cda into pingcap:release-7.1 May 26, 2023
7 checks passed
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels May 31, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-7.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants