Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: add remain time for information_schema.analyze_status #44294

Merged
merged 7 commits into from Jun 2, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented May 31, 2023

What problem does this PR solve?

Issue Number: close #44033

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 31, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • xuyifangreeneyes

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 31, 2023
@hawkingrei hawkingrei changed the title executor: add remain time for information_schema.analyze_status executor: add remain time for information_schema.analyze_status [DNM] May 31, 2023
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei hawkingrei changed the title executor: add remain time for information_schema.analyze_status [DNM] executor: add remain time for information_schema.analyze_status Jun 1, 2023
@hawkingrei hawkingrei requested a review from qw4990 June 1, 2023 07:09
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 1, 2023
infoschema/tables.go Outdated Show resolved Hide resolved
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
Copy link
Member Author

@time-and-fate PTAL

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 2, 2023
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 2, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 9bdab60

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 2, 2023
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jun 2, 2023
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 2, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 03254d6

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 2, 2023
@ti-chi-bot ti-chi-bot bot merged commit cf4dedf into pingcap:master Jun 2, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

more information in the analyze status
4 participants