Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store/gcworker: reduce "full config reset" log on pd side #44331

Merged
merged 1 commit into from Jun 1, 2023

Conversation

tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Jun 1, 2023

What problem does this PR solve?

Issue Number: close #33069

Problem Summary:

What is changed and how it works?

Similiar to #33082, reduce the duplicated request.

If there are N range to be deleted, there will be N logs like "full config reset" on the pd side.
It affects v6.1.1 and master both.

  1. (*GCWorker).deleteRanges execute doGCPlacementRules function for each DelRangeTask
    if err := w.doGCPlacementRules(se, safePoint, r, gcPlacementRuleCache); err != nil {
  2. doGCPlacementRules get the DDL history by the DelRangeTask.JobID
    historyJob, err = ddl.GetHistoryJobByID(se, dr.JobID)
  3. Retrive all the Physical Table IDs dropped by this DDL
    if err = historyJob.DecodeArgs(&startKey, &physicalTableIDs); err != nil {
  4. And delete all the Bundles for those Physical Table IDs
    return infosync.PutRuleBundlesWithDefaultRetry(context.TODO(), bundles)

There are many duplicated physical IDs during step 1 and step 3

In #33069 it add a cache to handle the Delete rule
But note this line

return infosync.PutRuleBundlesWithDefaultRetry(context.TODO(), bundles)
, there would still be duplicated request there, so pd print "full config reset" many times.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
update mysql.tidb set VARIABLE_VALUE = '3m' where VARIABLE_NAME = 'tikv_gc_run_interval';
update mysql.tidb set VARIABLE_VALUE = '3m' where VARIABLE_NAME = 'tikv_gc_life_time';

create table t (id int) partition by hash partitions 2000;
insert into t values (1),(2),(3), ....
insert into t select * from t;

drop table t;

wait 3min, check the pd log ...

After the fix, there would be only one line "full config reset" in the log for the drop table operation.

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 1, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lcwangchao
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 1, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 1, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 1, 2023
@lcwangchao
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 1, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 21093d7

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 1, 2023
@ti-chi-bot ti-chi-bot bot merged commit ea2e9b6 into pingcap:master Jun 1, 2023
8 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #44335.

@tiancaiamao
Copy link
Contributor Author

/cherry-pick release-6.5-20230425-v6.5.2

@ti-chi-bot
Copy link
Member

@tiancaiamao: new pull request created to branch release-6.5-20230425-v6.5.2: #44336.

In response to this:

/cherry-pick release-6.5-20230425-v6.5.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #44347.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #44348.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-6.1 needs-cherry-pick-release-6.5 needs-cherry-pick-release-7.1 release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5-20230425-v6.5.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tidb gc too slow after drop database with 60k tables
4 participants