-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: ebs tags refactoring (#44381) #44410
br: ebs tags refactoring (#44381) #44410
Conversation
Signed-off-by: BornChanger <dawn_catcher@126.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #44381
What problem does this PR solve?
Issue Number: close #43934
Problem Summary:
What is changed and how it works?
This pr refactored to
Check List
Tests
Unit test
Integration test
Manual test (add detailed scripts or steps below)
![NzQRMB46e8](https://private-user-images.githubusercontent.com/97348524/243313434-03d074fe-dff1-404f-996d-37fe5705c0d0.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQxNzU3MTIsIm5iZiI6MTcyNDE3NTQxMiwicGF0aCI6Ii85NzM0ODUyNC8yNDMzMTM0MzQtMDNkMDc0ZmUtZGZmMS00MDRmLTk5NmQtMzdmZTU3MDVjMGQwLmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODIwVDE3MzY1MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTA1NjVkODVmODZlNzdkM2E1MGQyYTQ3YzdjOTY3YjFjMjAxYThiNWY3OWNmMmQ2MWM1MmJiNDVlZjc3YzA1OGEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.pwNX7K4VAAQyMLqtBOaJ6zRSKlFQNZHgb0Koj7U1r50)
![IbzQ4OQfNM](https://private-user-images.githubusercontent.com/97348524/243313590-047dd6a8-be6a-41c5-8db2-80f2c9344dff.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQxNzU3MTIsIm5iZiI6MTcyNDE3NTQxMiwicGF0aCI6Ii85NzM0ODUyNC8yNDMzMTM1OTAtMDQ3ZGQ2YTgtYmU2YS00MWM1LThkYjItODBmMmM5MzQ0ZGZmLmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODIwVDE3MzY1MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWVjOWNjZmM0MTEzMWVkODEyNTdmMTIyYjFkMTI0NzFhNDc4YmQ5ZTNiZDcxYTY2ZjcyYzBlNTg2NTU2YjFiNmImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.RLwRFl-sh1Z_9n2wUtDw4LlUKLq43HNrMA-BYmKBMSo)
![img_v2_b33e957e-04ff-4fe2-a3b0-83ac5672cc5g](https://private-user-images.githubusercontent.com/97348524/243313652-746aef54-a8f6-4c99-b8c3-0f8ed157b785.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQxNzU3MTIsIm5iZiI6MTcyNDE3NTQxMiwicGF0aCI6Ii85NzM0ODUyNC8yNDMzMTM2NTItNzQ2YWVmNTQtYThmNi00Yzk5LWI4YzMtMGY4ZWQxNTdiNzg1LmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODIwVDE3MzY1MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTI1NDE3MWMzNjAwYjE5NzQ4YjNlOGMzNmE4OWJlMzRjYjg0OTE5NzViNzUxOTBhZTRiZTU1ODRmYTQxYTYxMGMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ZZJ2BxGeDru6hZ9b_dc5YINb6LvCZYBvTJU7DvJ2g48)
Verify the logic by EBS snapshot backup and restore, take one volume as example,
original tags
snapshot for the volume
tags for restored volume
No code
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.