Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning: fix uuid panic when expression index enabled (#44516) #44548

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #44516

What problem does this PR solve?

Issue Number: close #44497

Problem Summary:

What is changed and how it works?

Add e.SessionCtx.Vars.TxnCtx when getting default value for column with default expression.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    manually load data with uuid and it works.

Side effects

  • None

Documentation

  • None

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

lightning: fix the problem that lightning crashes when target table has a column whose default value is uuid

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 labels Jun 9, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 9, 2023
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 9, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 9, 2023
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lichunzhu
Copy link
Contributor

/run-integration-br-tests

@lichunzhu
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot removed the lgtm label Jun 9, 2023
@lichunzhu
Copy link
Contributor

/run-integration-br-tests

Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lance6716
Copy link
Contributor

/approve

@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 9, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, lance6716, lichunzhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [GMHDBJD,lance6716,lichunzhu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 9, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-09 08:11:27.535792209 +0000 UTC m=+72301.783714034: ☑️ agreed by GMHDBJD.
  • 2023-06-09 08:12:02.994123941 +0000 UTC m=+72337.242045766: ☑️ agreed by lance6716.
  • 2023-06-09 08:30:44.003661428 +0000 UTC m=+73458.251583277: ✖️🔁 reset by lichunzhu.
  • 2023-06-09 09:00:02.727625219 +0000 UTC m=+75216.975547045: ☑️ agreed by GMHDBJD.
  • 2023-06-09 09:03:54.323780099 +0000 UTC m=+75448.571701924: ☑️ agreed by lichunzhu.

@ti-chi-bot ti-chi-bot bot merged commit 43cf5ea into pingcap:release-6.5 Jun 9, 2023
14 of 15 checks passed
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Jun 14, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants