Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: support limit_to_cop, agg_to_cop, ordered_index, no_ordered_index for quick binding #44611

Merged
merged 24 commits into from Jun 13, 2023

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jun 13, 2023

What problem does this PR solve?

Issue Number: ref #39199

Problem Summary: planner: support limit_to_cop for quick binding

What is changed and how it works?

planner: support limit_to_cop for quick binding

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 13, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 13, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 13, 2023
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 13, 2023

/test check-dev

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 13, 2023
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 13, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 13, 2023

@hawkingrei: Your lgtm message is repeated, so it is ignored.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990 qw4990 requested a review from hawkingrei June 13, 2023 13:53
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 13, 2023

@hawkingrei: Your lgtm message is repeated, so it is ignored.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 13, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, time-and-fate, xuyifangreeneyes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,time-and-fate,xuyifangreeneyes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 13, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-13 06:11:28.654170592 +0000 UTC m=+66085.068774663: ☑️ agreed by hawkingrei.
  • 2023-06-13 07:19:27.318278406 +0000 UTC m=+70163.732882485: ☑️ agreed by xuyifangreeneyes.
  • 2023-06-13 07:51:37.190898804 +0000 UTC m=+72093.605502883: ✖️🔁 reset by qw4990.
  • 2023-06-13 13:46:19.121438786 +0000 UTC m=+93375.536042864: ☑️ agreed by hawkingrei.
  • 2023-06-13 13:54:05.895263405 +0000 UTC m=+93842.309867481: ☑️ agreed by time-and-fate.

@qw4990
Copy link
Contributor Author

qw4990 commented Jun 13, 2023

/merge

@ti-chi-bot ti-chi-bot bot merged commit 0f7cae3 into pingcap:master Jun 13, 2023
8 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #44678.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jun 14, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@qw4990 qw4990 changed the title planner: support limit_to_cop for quick binding planner: support limit_to_cop, agg_to_cop, ordered_index, no_ordered_index for quick binding Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.1 release-note-none size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants