Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix fileperm on bazel RBE #44624

Merged
merged 1 commit into from Jun 13, 2023
Merged

*: fix fileperm on bazel RBE #44624

merged 1 commit into from Jun 13, 2023

Conversation

xhebox
Copy link
Contributor

@xhebox xhebox commented Jun 13, 2023

What problem does this PR solve?

Issue Number: close #44626

Problem Summary: fileperm linters are not working on bazel RBE environemnt, where all files are 555. Add a flag to disable this linter.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox xhebox requested a review from hawkingrei June 13, 2023 10:04
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Jun 13, 2023
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [YangKeao,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 13, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-13 10:08:17.627784268 +0000 UTC m=+80294.042388347: ☑️ agreed by hawkingrei.
  • 2023-06-13 10:58:59.524630882 +0000 UTC m=+83335.939234966: ☑️ agreed by YangKeao.

@hawkingrei
Copy link
Member

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 13, 2023
@hawkingrei
Copy link
Member

I have tested it. It can work.

Good Job!

@hawkingrei
Copy link
Member

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 13, 2023
@ti-chi-bot ti-chi-bot bot merged commit 17ae6f6 into pingcap:master Jun 13, 2023
8 checks passed
@xhebox xhebox deleted the fix_2 branch June 14, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TiDB fail to run test on the RBE
3 participants