import into: redact sensitive info & check active job before create #44674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
size/XL
D3Hunter
changed the title
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/hold |
ti-chi-bot
bot
added
the
do-not-merge/hold
lance6716
approved these changes
Jun 15, 2023
| // todo: we don't need to do it here, remove it. | ||
| if err2 := e.controller.InitDataFiles(ctx); err2 != nil { | ||
| return err2 | ||
| } | ||
|
|
||
| sqlExec := e.userSctx.(sqlexec.SQLExecutor) | ||
| if err2 := e.controller.CheckRequirements(ctx, sqlExec); err2 != nil { | ||
| // must use a new session to pre-check, else the stmt in show processlist will be changed. |
There was a problem hiding this comment.
maybe ExecuteInternal will not change show processlist
There was a problem hiding this comment.
we're using it already
sql := fmt.Sprintf("SELECT 1 FROM %s USE INDEX() LIMIT 1", common.UniqueTable(e.DBName, e.Table.Meta().Name.L))
rs, err := conn.ExecuteInternal(ctx, sql)
|
/unhold |
ti-chi-bot
bot
removed
the
do-not-merge/hold
|
/hold |
ti-chi-bot
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bb7133, GMHDBJD, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
ti-chi-bot
bot
removed
the
do-not-merge/hold
|
/retest |
1 similar comment
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #42930
Problem Summary:
What is changed and how it works?
show processlistshow processlistreturns incorrect sqlCheck List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.