-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lightning: duplicate resolution support to use DELETE to cleanup clustered table #44799
Merged
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a47961f
lightning: duplicate resolution support to use DELETE to cleanup
lance6716 b6355f8
fix CI
lance6716 496186b
fix CI
lance6716 e720391
uncomment
lance6716 cf26eda
fix bazel_prepare
lance6716 5da04a9
Merge branch 'master' of github.com:pingcap/tidb into delete-dedup
lance6716 7338cc1
address comment
lance6716 5a28767
fix bazel
lance6716 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
// Copyright 2023 PingCAP, Inc. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package kv_test | ||
|
||
import ( | ||
"testing" | ||
|
||
"github.com/pingcap/tidb/br/pkg/lightning/backend/encode" | ||
"github.com/pingcap/tidb/br/pkg/lightning/backend/kv" | ||
"github.com/pingcap/tidb/br/pkg/lightning/log" | ||
"github.com/pingcap/tidb/ddl" | ||
"github.com/pingcap/tidb/parser" | ||
"github.com/pingcap/tidb/parser/ast" | ||
"github.com/pingcap/tidb/parser/model" | ||
"github.com/pingcap/tidb/parser/mysql" | ||
"github.com/pingcap/tidb/sessionctx/variable" | ||
"github.com/pingcap/tidb/table/tables" | ||
"github.com/pingcap/tidb/types" | ||
"github.com/pingcap/tidb/util/mock" | ||
"github.com/stretchr/testify/require" | ||
) | ||
|
||
func TestIterRawIndexKeysClusteredPK(t *testing.T) { | ||
p := parser.New() | ||
node, _, err := p.ParseSQL("create table t (a varchar(10) primary key, b int, index idx(b));") | ||
require.NoError(t, err) | ||
mockSctx := mock.NewContext() | ||
mockSctx.GetSessionVars().EnableClusteredIndex = variable.ClusteredIndexDefModeOn | ||
info, err := ddl.MockTableInfo(mockSctx, node[0].(*ast.CreateTableStmt), 1) | ||
require.NoError(t, err) | ||
info.State = model.StatePublic | ||
require.True(t, info.IsCommonHandle) | ||
tbl, err := tables.TableFromMeta(kv.NewPanickingAllocators(0), info) | ||
require.NoError(t, err) | ||
|
||
sessionOpts := &encode.SessionOptions{ | ||
SQLMode: mysql.ModeStrictAllTables, | ||
Timestamp: 1234567890, | ||
} | ||
decoder, err := kv.NewTableKVDecoder(tbl, "`test`.`c1`", sessionOpts, log.L()) | ||
require.NoError(t, err) | ||
|
||
sctx := kv.NewSession(sessionOpts, log.L()) | ||
handle, err := tbl.AddRecord(sctx, []types.Datum{types.NewIntDatum(1), types.NewIntDatum(2)}) | ||
require.NoError(t, err) | ||
paris := sctx.TakeKvPairs() | ||
_, rowValue := paris.Pairs[0].Key, paris.Pairs[0].Val | ||
idxKey := paris.Pairs[1].Key | ||
|
||
deleteKeys := make([][]byte, 0, 2) | ||
err = decoder.IterRawIndexKeys(handle, rowValue, func(bs []byte) error { | ||
deleteKeys = append(deleteKeys, bs) | ||
return nil | ||
}) | ||
require.NoError(t, err) | ||
|
||
expected := [][]byte{idxKey} | ||
require.Equal(t, expected, deleteKeys) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we skip
clustered & single-int column
kind of pk?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added test 7338cc1
When PKIsHandle (test file line 83), I remember the PK will not appear in
indices
, so no need to skip it.