*: Add GEOMETRY column type #44849
*: Add GEOMETRY column type #44849
Conversation
|
Skipping CI for Draft Pull Request. |
ti-chi-bot
bot
added
do-not-merge/work-in-progress
|
/test all |
dveeden
force-pushed
the
geometry_type
branch
2 times, most recently
from
9f9bd27
to
6d208ea
Compare
|
/retest |
dveeden
force-pushed
the
geometry_type
branch
2 times, most recently
from
f2fcc61
to
4276847
Compare
|
/retest |
|
/retest |
ti-chi-bot
bot
removed
the
do-not-merge/work-in-progress
|
/test tiprow_test |
|
/test tiprow_fast_test |
|
@hawkingrei: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
types/datum.go
Outdated
| fromBinary := d.Collation() == charset.CollationBin | ||
| toBinary := target.GetCharset() == charset.CharsetBin | ||
| if fromBinary && toBinary { | ||
| s = d.GetString() | ||
| } else if fromBinary { | ||
| s, err = d.GetBinaryStringDecoded(sc, target.GetCharset()) | ||
| } else if toBinary { | ||
| s = d.GetBinaryStringEncoded() | ||
| } else { | ||
| s, err = d.GetStringWithCheck(sc, target.GetCharset()) | ||
| } |
There was a problem hiding this comment.
This does not seem to be covered by the tests.
types/datum.go
Outdated
| case KindBinaryLiteral: | ||
| s, err = d.GetBinaryStringDecoded(sc, target.GetCharset()) | ||
| default: | ||
| return invalidConv(d, target.GetType()) |
ti-chi-bot
bot
added
the
needs-rebase
Yes, I think so. You can check by unstaging the changes to |
|
/ok-to-test |
ti-chi-bot
bot
removed
the
needs-rebase
ti-chi-bot
bot
added
the
needs-rebase
ti-chi-bot
bot
added
needs-rebase
|
/retest |
|
/test all |
|
/retest |
ti-chi-bot
bot
added
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #44849 +/- ##
================================================
+ Coverage 71.0442% 73.2382% +2.1939%
================================================
Files 1368 1259 -109
Lines 402977 388666 -14311
================================================
- Hits 286292 284652 -1640
+ Misses 96744 85765 -10979
+ Partials 19941 18249 -1692
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dveeden
force-pushed
the
geometry_type
branch
from
3456b68
to
1468d65
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
the
do-not-merge/work-in-progress
dveeden
removed
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ti-chi-bot
bot
added
the
needs-rebase
|
@dveeden: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@dveeden: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: ref #6347
Problem Summary:
This adds a new column type:
GEOMETRYthat is compatible with MySQL.This stores values in the format used by mysql
This is only the column type and does not yet add any functions for working with these. This is to limit the current scope. This makes it possible to migrate data from MySQL and view this data in tools like DBeaver. This also doesn't add support for SRID constraints yet.
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.