Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(br): support run group br&lightning tests #44957

Merged
merged 18 commits into from Jul 3, 2023
Merged

ci(br): support run group br&lightning tests #44957

merged 18 commits into from Jul 3, 2023

Conversation

purelind
Copy link
Contributor

@purelind purelind commented Jun 26, 2023 •
edited

What problem does this PR solve?

Issue Number: close #45006

Problem Summary:

What is changed and how it works?

  1. Use relative paths to locate the binary and support direct execution of test scripts, instead of moving the test directory to a specified path. Currently, we need to move all test directories in br/tests/ to tests/ in order to start the testing.
  2. Add a script to support running multiple integration test cases in pipelines pull-br-integration-test
  3. Trigger new br&lightning pipeline by /test pull-br-integration-test

Check List

Tests

  • No code

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@purelind
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 26, 2023
@tiprow
Copy link

tiprow bot commented Jun 26, 2023

Hi @purelind. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@purelind
Copy link
Contributor Author

/test pull-integration-br-test

@tiprow
Copy link

tiprow bot commented Jun 26, 2023

@purelind: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-integration-br-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@purelind purelind marked this pull request as draft June 27, 2023 08:10
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 27, 2023
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 27, 2023
@purelind purelind marked this pull request as ready for review June 28, 2023 03:08
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 28, 2023
@purelind
Copy link
Contributor Author

/test pull-integration-br-test

@D3Hunter
Copy link
Contributor

/ok-to-test

@pingcap pingcap deleted a comment from tiprow bot Jun 28, 2023
@purelind
Copy link
Contributor Author

/test pull-br-integration-test

@tiprow
Copy link

tiprow bot commented Jun 29, 2023

@purelind: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@purelind
Copy link
Contributor Author

/test check-dev2

@purelind
Copy link
Contributor Author

/run-integration-br-test

@tiprow
Copy link

tiprow bot commented Jun 29, 2023

@purelind: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wuhuizuo
wuhuizuo reviewed Jun 29, 2023
View reviewed changes
br/tests/run_group.sh Outdated Show resolved Hide resolved
@wuhuizuo
Copy link
Contributor

/review default

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 29, 2023

@wuhuizuo:
I Skip it since the diff size(102041 bytes > 80000 bytes) is too large

In response to this:

/review default

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@purelind
Copy link
Contributor Author

/test pull-br-integration-test

@tiprow
Copy link

tiprow bot commented Jun 29, 2023

@purelind: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@purelind
Copy link
Contributor Author

/retest

@purelind
Copy link
Contributor Author

/run-integration-br-test

@purelind purelind changed the title ci: support run group br&lightning tests ci(br): support run group br&lightning tests Jun 30, 2023
@purelind
Copy link
Contributor Author

/retest

@purelind
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2023
@purelind
Copy link
Contributor Author

/cc @3pointer @D3Hunter @lance6716

@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 3, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 3, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-03 04:11:11.240631959 +0000 UTC m=+4303.174265380: ☑️ agreed by lance6716.
  • 2023-07-03 06:22:13.341831488 +0000 UTC m=+12165.275464911: ☑️ agreed by D3Hunter.

@ti-chi-bot ti-chi-bot bot merged commit 301357e into pingcap:master Jul 3, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wuhuizuo wuhuizuo wuhuizuo left review comments

@lance6716 lance6716 lance6716 approved these changes

@D3Hunter D3Hunter D3Hunter approved these changes

@3pointer 3pointer Awaiting requested review from 3pointer

Assignees
No one assigned
Labels
approved lgtm ok-to-test release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Must move the "br" test directory in order to execute the test script properly
4 participants
@purelind @D3Hunter @wuhuizuo @lance6716