executor: add cache for approximate table count #44979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
size/L
hawkingrei
changed the title
hawkingrei
force-pushed
the
add_cache_cnt
branch
from
c3c9255
to
230e027
Compare
hawkingrei
commented
Jun 27, 2023
| // GetApproximateTableCountFromStorage gets the approximate count of the table. | ||
| func (p *PDHelper) GetApproximateTableCountFromStorage(sctx sessionctx.Context, tid int64, dbName, tableName, partitionName string) (float64, bool) { | ||
| key := approximateTableCountKey(tid, dbName, tableName, partitionName) | ||
| if item := p.cacheForApproximateTableCountFromStorage.Get(key); item != nil { |
There was a problem hiding this comment.
GetApproximateTableCountFromStorage is the same as the old. but we add cache here.
|
/retest |
1 similar comment
|
/retest |
tidb-server/main.go
Outdated
| @@ -760,6 +761,7 @@ func setGlobalVars() { | |||
| } else { | |||
| executor.GlobalMemoryUsageTracker.SetBytesLimit(int64(cfg.Performance.ServerMemoryQuota)) | |||
| } | |||
| executor.Start() | |||
There was a problem hiding this comment.
Why do we put this in setGlobalVars?
Seems a bit confusing.
There was a problem hiding this comment.
I hope it is globally unique.
There was a problem hiding this comment.
+1. My main points are:
- Currently, we only set up global states, i.e. setting global variables in
setGlobalVars. Butexecutor.Start()starts a background goroutine, which is quite different. - If we call
executor.Start()here andexecutor.Stop()inmain(), they won't pair up and will make the code a bit confusing.
| @@ -183,6 +184,16 @@ func init() { | |||
| CheckTableFastBucketSize.Store(1024) | |||
| } | |||
|
|
|||
| // Start the backend components | |||
There was a problem hiding this comment.
I suggest add some comments since we are introducing the "backend components" new concept to this package.
chrysan
reviewed
Jun 29, 2023
chrysan
reviewed
Jun 29, 2023
chrysan
reviewed
Jun 29, 2023
ti-chi-bot
bot
added
the
needs-rebase
ti-chi-bot
bot
added
size/XL
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
ti-chi-bot
bot
removed
the
needs-rebase
time-and-fate
approved these changes
Jul 3, 2023
chrysan
approved these changes
Jul 3, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrysan, time-and-fate The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #44978
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.