Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: cleanup AvaliablePartitionIDs for tiflash when restore #45016

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Jun 28, 2023

What problem does this PR solve?

Issue Number: close #45013

Problem Summary:
when do snapshot restore, br should cleanup the table's TiflashReplica.AvaliableParitionIDs.

What is changed and how it works?

cleanup the table's TiflashReplica.AvaliableParitionIDs when create the table.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.5 release-note-none needs-cherry-pick-release-7.1 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 28, 2023
@tiprow
Copy link

tiprow bot commented Jun 28, 2023

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-28 07:27:51.338627216 +0000 UTC m=+779036.739877650: ☑️ agreed by 3pointer.
  • 2023-06-28 09:00:08.558050964 +0000 UTC m=+784573.959301413: ☑️ agreed by YuJuncen.

@Leavrth
Copy link
Contributor Author

Leavrth commented Jun 28, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot bot merged commit a7b54ad into pingcap:master Jun 28, 2023
26 of 27 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #45027.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jun 28, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #45030.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jun 28, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the AvailablePartitionIDs of the table is not reset when the table is created by snapshot restore
4 participants