Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: split executor_test #45020

Merged
merged 2 commits into from Jun 28, 2023
Merged

executor: split executor_test #45020

merged 2 commits into from Jun 28, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jun 28, 2023 •
edited

What problem does this PR solve?

Issue Number: close #44940

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@hawkingrei
executor: split executor_test
ad616e5 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Jun 28, 2023
@hawkingrei
executor: split executor_test
6991e6b 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
YangKeao
YangKeao approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wshwsh12, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-28 07:39:57.721803109 +0000 UTC m=+779763.123053553: ☑️ agreed by YangKeao.
  • 2023-06-28 07:45:37.268247031 +0000 UTC m=+780102.669497479: ☑️ agreed by wshwsh12.

@ti-chi-bot ti-chi-bot bot merged commit 9fc80a9 into pingcap:master Jun 28, 2023
8 of 9 checks passed
@hawkingrei hawkingrei deleted the split_expression branch June 28, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YangKeao YangKeao YangKeao approved these changes

@wshwsh12 wshwsh12 wshwsh12 approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Splitting Test Directories to Increase Test Concurrency and Optimize Cache
3 participants
@hawkingrei @YangKeao @wshwsh12