Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: embed failpoint into bazel #45120

Merged
merged 4 commits into from Jul 10, 2023
Merged

*: embed failpoint into bazel #45120

merged 4 commits into from Jul 10, 2023

Conversation

xhebox
Copy link
Contributor

@xhebox xhebox commented Jul 3, 2023

What problem does this PR solve?

Issue Number: close None

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@xhebox xhebox requested a review from hawkingrei July 3, 2023 07:36
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 3, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/invalid-title do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 3, 2023
@xhebox xhebox changed the title [WIP] embed failpoint into bazel [WIP] *: embed failpoint into bazel Jul 3, 2023
@tiprow
Copy link

tiprow bot commented Jul 3, 2023

Hi @xhebox. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xhebox
Copy link
Contributor Author

xhebox commented Jul 3, 2023

/test all

@tiprow
Copy link

tiprow bot commented Jul 3, 2023

@xhebox: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xhebox xhebox changed the title [WIP] *: embed failpoint into bazel *: embed failpoint into bazel [WIP] Jul 3, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 3, 2023
@hawkingrei
Copy link
Member

/ok-to-test

@hawkingrei hawkingrei marked this pull request as ready for review July 3, 2023 07:51
@ti-chi-bot ti-chi-bot bot added ok-to-test and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 3, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 3, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 3, 2023
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 7, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 7, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 7, 2023
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 7, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 7, 2023
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@xhebox xhebox changed the title *: embed failpoint into bazel [WIP] *: embed failpoint into bazel Jul 7, 2023
@hawkingrei
Copy link
Member

/hold

wait for testing again to test cache.

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2023
@hawkingrei
Copy link
Member

/test all

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 7, 2023

@xhebox: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-br-integration-test f20e38a8066125d40f977b96b1b91c4b16ec2798 link true /test pull-br-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 7, 2023
@xhebox
Copy link
Contributor Author

xhebox commented Jul 10, 2023

/test check_dev

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 10, 2023

@xhebox: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test canary-scan-security
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test pingcap/tidb/canary_ghpr_unit_test
  • /test pull-br-integration-test
  • /test pull-e2e-test
  • /test pull-integration-copr-test
  • /test pull-integration-jdbc-test
  • /test pull-integration-mysql-test
  • /test unit-test

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tidb/ghpr_build
  • pingcap/tidb/ghpr_check
  • pingcap/tidb/ghpr_check2
  • pingcap/tidb/ghpr_mysql_test
  • pingcap/tidb/ghpr_unit_test

In response to this:

/test check_dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiprow
Copy link

tiprow bot commented Jul 10, 2023

@xhebox: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test check_dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xhebox
Copy link
Contributor Author

xhebox commented Jul 10, 2023

/test check-dev

@tiprow
Copy link

tiprow bot commented Jul 10, 2023

@xhebox: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xhebox
Copy link
Contributor Author

xhebox commented Jul 10, 2023

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 10, 2023

@hawkingrei: Your lgtm message is repeated, so it is ignored.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 10, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 10, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-07 09:40:01.846250934 +0000 UTC m=+65693.616589661: ☑️ agreed by hawkingrei.
  • 2023-07-10 03:32:38.589924734 +0000 UTC m=+302850.360263446: ☑️ agreed by Defined2014.

@hawkingrei
Copy link
Member

/test tiprow_fast_test

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 10, 2023

@hawkingrei: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test canary-scan-security
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test pingcap/tidb/canary_ghpr_unit_test
  • /test pull-br-integration-test
  • /test pull-e2e-test
  • /test pull-integration-copr-test
  • /test pull-integration-jdbc-test
  • /test pull-integration-mysql-test
  • /test unit-test

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tidb/ghpr_build
  • pingcap/tidb/ghpr_check
  • pingcap/tidb/ghpr_check2
  • pingcap/tidb/ghpr_mysql_test
  • pingcap/tidb/ghpr_unit_test

In response to this:

/test tiprow_fast_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit cae877b into pingcap:master Jul 10, 2023
9 checks passed
hawkingrei added a commit that referenced this pull request Jul 11, 2023
@xhebox xhebox deleted the ee branch April 7, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-issue-check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants