infoschema: Don't truncate versions

[dveeden]

What problem does this PR solve?

Issue Number: ref #16302

Problem Summary:

Before (7.3.0-alpha):

mysql> TABLE information_schema.CLUSTER_INFO;
+------+-----------------+-----------------+-------------+------------------------------------------+---------------------+---------------+-----------+
| TYPE | INSTANCE        | STATUS_ADDRESS  | VERSION     | GIT_HASH                                 | START_TIME          | UPTIME        | SERVER_ID |
+------+-----------------+-----------------+-------------+------------------------------------------+---------------------+---------------+-----------+
| tidb | 127.0.0.1:4000  | 127.0.0.1:10080 | 7.3.0-alpha | 8c71149116f9439713604d3bf737156a2735b963 | 2023-07-06 15:14:07 | 12.962112656s |   1561139 |
| pd   | 127.0.0.1:2379  | 127.0.0.1:2379  | 7.2.0       | 0934e641129d8bac3c5975372b2ce492b81fd9db | 2023-07-06 15:13:54 | 25.962125837s |         0 |
| tikv | 127.0.0.1:20160 | 127.0.0.1:20180 | 7.2.0       | 12ce5540f9e8f781f14d3b3a58fb9442f03b6b29 | 2023-07-06 15:13:57 | 22.962131038s |         0 |
+------+-----------------+-----------------+-------------+------------------------------------------+---------------------+---------------+-----------+
3 rows in set (0.00 sec)

After (7.3.0-alpha-128-g967699a509-dirty):

mysql> TABLE information_schema.CLUSTER_INFO;
+------+-------------------+--------------------+-----------------------------------+------------------------------------------+---------------------------+--------------+-----------+
| TYPE | INSTANCE          | STATUS_ADDRESS     | VERSION                           | GIT_HASH                                 | START_TIME                | UPTIME       | SERVER_ID |
+------+-------------------+--------------------+-----------------------------------+------------------------------------------+---------------------------+--------------+-----------+
| tidb | 192.168.1.54:4000 | 192.168.1.54:10080 | 7.3.0-alpha-128-g967699a509-dirty | 967699a50938848bcd3504a43856d5487af2d0b3 | 2023-07-06T15:24:54+02:00 | 552.343537ms |         1 |
| tikv | store1            |                    |                                   |                                          |                           |              |         0 |
+------+-------------------+--------------------+-----------------------------------+------------------------------------------+---------------------------+--------------+-----------+
2 rows in set (0.00 sec)

What is changed and how it works?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

The versions in `information_schema.cluster_info` are no longer truncated on the first `-`.

[tiprow]

Hi @dveeden. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dveeden]

/ok-to-test

[xhebox]

What about adding two more versions than modifying existed cases?

[dveeden]

I didn't modify the existing test cases, I only modified the results.

Input	Previous output	New output
"5.7.25-TiDB-v4.0.0-beta-446-g5268094af"	"4.0.0-beta""	"4.0.0-beta-446-g5268094af"
"5.7.25-TiDB-v4.0.0-TiDB-446"	"4.0.0-TiDB"	"4.0.0-TiDB-446"

I've pushed a88e55e to refactor the test and make this a bit more obvious.

[dveeden]

/test tiprow_fast_test

[ti-chi-bot]

@dveeden: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test build
• /test canary-scan-security
• /test check-dev
• /test check-dev2
• /test mysql-test
• /test pingcap/tidb/canary_ghpr_unit_test
• /test pull-br-integration-test
• /test pull-e2e-test
• /test pull-integration-copr-test
• /test pull-integration-jdbc-test
• /test pull-integration-mysql-test
• /test unit-test

Use /test all to run the following jobs that were automatically triggered:

• pingcap/tidb/ghpr_build
• pingcap/tidb/ghpr_check
• pingcap/tidb/ghpr_check2
• pingcap/tidb/ghpr_mysql_test
• pingcap/tidb/ghpr_unit_test

In response to this:

/test tiprow_fast_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dveeden]

/retest

[hawkingrei]

/retest

[tiprow]

@dveeden: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
tiprow_fast_test	a88e55e	link	true	/test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[zimulala]

LGTM

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [xhebox,zimulala]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2023-07-10 09:58:18.622690487 +0000 UTC m=+325990.393029194: ☑️ agreed by xhebox.
• 2023-07-10 11:26:32.201266821 +0000 UTC m=+331283.971605533: ☑️ agreed by zimulala.