Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: disable modify column combine auto_increment with default value #45235

Merged
merged 1 commit into from Jul 10, 2023

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Jul 7, 2023

What problem does this PR solve?

Issue Number: close #45136

Problem Summary: Let the behaviour same as MySQL.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 7, 2023
@tiprow
Copy link

tiprow bot commented Jul 7, 2023

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Defined2014 Defined2014 requested a review from zimulala July 7, 2023 09:27
@Defined2014 Defined2014 changed the title ddl: disable modify column to combine auto_increment with default value ddl: disable modify column combine auto_increment with default value Jul 10, 2023
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 10, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 10, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-10 02:26:21.109104269 +0000 UTC m=+298872.879442981: ☑️ agreed by zimulala.
  • 2023-07-10 02:58:39.162069115 +0000 UTC m=+300810.932407829: ☑️ agreed by tangenta.

@ti-chi-bot ti-chi-bot bot merged commit 9981946 into pingcap:master Jul 10, 2023
9 checks passed
@Defined2014 Defined2014 deleted the fix-45136 branch July 10, 2023 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AUTO_INCREMENT relates to a restriction whose behavior is inconsistent with the document description.
3 participants