Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dumpling: skip query tables when use --sql #45240

Merged
merged 4 commits into from Jul 10, 2023

Conversation

lance6716
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #45239

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 needs-cherry-pick-release-6.1 needs-cherry-pick-release-6.5 needs-cherry-pick-release-7.1 size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 7, 2023
@lance6716
Copy link
Contributor Author

/cc @lichunzhu @okJiang

@ti-chi-bot ti-chi-bot bot requested review from lichunzhu and okJiang July 7, 2023 13:07
@tiprow
Copy link

tiprow bot commented Jul 7, 2023

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lance6716
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test label Jul 7, 2023
@tiprow
Copy link

tiprow bot commented Jul 7, 2023

@lance6716: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test 26d7513 link true /test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@D3Hunter
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lichunzhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 10, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-10 02:12:33.513857838 +0000 UTC m=+298045.284196541: ☑️ agreed by D3Hunter.
  • 2023-07-10 07:43:22.896510566 +0000 UTC m=+317894.666849278: ☑️ agreed by lichunzhu.

@ti-chi-bot ti-chi-bot bot merged commit cb3fc6a into pingcap:master Jul 10, 2023
8 of 9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #45261.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 10, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #45262.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 10, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #45264.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 10, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@lance6716
Copy link
Contributor Author

/cherry-pick release-6.5-20230710-v6.5.2

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #45265.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 10, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

@lance6716: new pull request created to branch release-6.5-20230710-v6.5.2: #45266.

In response to this:

/cherry-pick release-6.5-20230710-v6.5.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 10, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request Jul 10, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Jul 13, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No need to query all databases and tables when use --sql in dumpling
4 participants