Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: extract resultset package out of server package #45270

Merged
merged 1 commit into from Jul 11, 2023

Conversation

YangKeao
Copy link
Member

What problem does this PR solve?

Issue Number: close #45263

Problem Summary:

Extract the *ResultSet* functions, interfaces and structs out from the /server pkg.

@ti-chi-bot ti-chi-bot bot added do-not-merge/invalid-title size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 10, 2023
@YangKeao YangKeao changed the title extract resultset package out of server package server: extract resultset package out of server package Jul 10, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 10, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 10, 2023
@YangKeao YangKeao marked this pull request as draft July 10, 2023 09:24
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 10, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 10, 2023
@YangKeao YangKeao marked this pull request as ready for review July 11, 2023 07:15
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 11, 2023
@YangKeao
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 11, 2023
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@tiprow
Copy link

tiprow bot commented Jul 11, 2023

@YangKeao: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test b78344b link true /test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 11, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 11, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-11 08:01:57.881520542 +0000 UTC m=+405409.651859259: ☑️ agreed by xhebox.
  • 2023-07-11 08:03:00.892426979 +0000 UTC m=+405472.662765692: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot merged commit 551b044 into pingcap:master Jul 11, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move tidbResultSet and tidbCursorResultSet to the sub-pkg of server
3 participants