New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix having clause item that ref-ed to grouping set expression shouldn't be pushed down through Expand OP #45651
planner: fix having clause item that ref-ed to grouping set expression shouldn't be pushed down through Expand OP #45651
Conversation
Hi @AilinKid. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
// Extract agg funcs from order by clause. | ||
if sel.OrderBy != nil { | ||
extractor.curClause = orderByClause | ||
for _, item := range sel.OrderBy.Items { | ||
extractor.inExpr = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is for two order by item says:
[year+2, profit]
it will identify profit column with flag 'IN EXPR', just fix it here too
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #45651 +/- ##
================================================
+ Coverage 73.2002% 73.6490% +0.4487%
================================================
Files 1265 1269 +4
Lines 390134 394892 +4758
================================================
+ Hits 285579 290834 +5255
+ Misses 86238 85703 -535
- Partials 18317 18355 +38
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…'t pushed down through Expand OP Signed-off-by: AilinKid <314806019@qq.com>
Signed-off-by: AilinKid <314806019@qq.com>
e90ef87
to
52f9d6f
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qw4990, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/merge |
@AilinKid: We have migrated to builtin Please use
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #45647
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.