expression: remove the usage of "TypeClass" in "expression.go" #4571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
XuHuaiyu
reviewed
Sep 20, 2017
| @@ -218,7 +218,8 @@ func evalExprToString(expr Expression, row []types.Datum, _ *variable.StatementC | |||
| if val.IsNull() || err != nil { | |||
| return res, val.IsNull(), errors.Trace(err) | |||
| } | |||
| if expr.GetTypeClass() == types.ClassString || IsHybridType(expr) { | |||
| exprEvalTp := fieldTp2EvalTp(expr.GetType()) | |||
| if exprEvalTp == tpString || exprEvalTp == tpJSON || IsHybridType(expr) { | |||
There was a problem hiding this comment.
why not check tpDatetime, tpTimestamp here?
There was a problem hiding this comment.
it should be checked in evalTime
|
LGTM |
coocood
added
status/LGT2
hanfei1991
deleted the
zz-jason/remove/typeclass/expression/expression
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to #4394