*: upgrade go1.20.7 #45741
*: upgrade go1.20.7 #45741
Conversation
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
size/XS
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #45741 +/- ##
================================================
+ Coverage 73.3396% 73.6544% +0.3147%
================================================
Files 1271 1274 +3
Lines 392943 396017 +3074
================================================
+ Hits 288183 291684 +3501
+ Misses 86386 86040 -346
+ Partials 18374 18293 -81
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Doesn't this conflict with #45634 ? |
|
/review how to make it upgrade automatic by dependabot or renovate? |
|
https://go.dev/doc/devel/release "go1.20.7 (released 2023-08-01) includes a security fix to the crypto/tls package, as well as bug fixes to the assembler and the compiler. See the Go 1.20.7 milestone on our issue tracker for details." |
|
@wuhuizuo: However, I noticed that the title of the pull request is not following the recommended format. The title should include the package name(s) that are being upgraded. For instance, if you are upgrading multiple packages, you should list them in the title like this: "pkg1, pkg2: upgrade to version x.y.z". If you are upgrading all packages, you should use an asterisk like this: "*: upgrade to version x.y.z". Regarding your question about automatic upgrades, you can use Dependabot or Renovate to keep your dependencies up-to-date. Both tools can be configured to automatically create pull requests for upgrading your packages. As for this pull request, I think it looks good, and I don't see any issues with it. I suggest that you update the pull request title to follow the recommended format and merge it if there are no objections. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/review how to make it upgrade automatic by renovate, please give me a detail configuration guide to reach it. |
|
@wuhuizuo:
{
"extends": [
"config:base",
":disableRateLimiting"
],
"packageRules": [
{
"packageNames": [
"^go$"
],
"versioning": "go"
}
]
}This configuration tells Renovate to look for
With these steps, Renovate will automatically upgrade your In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Should any of the other go 1.20.* versions be upgraded as well?
Dockerfile:ENV GOLANG_VERSION 1.20.5
Dockerfile.enterprise:ENV GOLANG_VERSION 1.20.5
WORKSPACE: version = "1.20.6",
WORKSPACE.patchgo: "darwin_amd64": ("go1.20.5.darwin-amd64.tar.gz", "4524fac6858f8170941bb023d218c4a322a38c6b565d7b83f8a80f525c507079"),
WORKSPACE.patchgo: "darwin_arm64": ("go1.20.5.darwin-arm64.tar.gz", "9bb1564c241e97d9c254a61136601da8a241e11aaa4ff70e5ad2505c5d1e27d1"),
WORKSPACE.patchgo: "linux_amd64": ("go1.20.5.linux-amd64.tar.gz", "22ddd3f4fa13b55dbccce1b8d6e86907aaae624f71caaf6524da1f382c055a03"),
WORKSPACE.patchgo: "linux_arm64": ("go1.20.5.linux-arm64.tar.gz", "b0372223fa83123df4166bcfb7c03a30bea20fa226b8c2a8c53aeb61060800d6"),
WORKSPACE.patchgo: version = "1.20.5",
br/web/package-lock.json: "version": "1.20.0",
br/web/package-lock.json: "resolved": "https://registry.npmjs.org/resolve/-/resolve-1.20.0.tgz",
br/web/package-lock.json: "version": "1.20.0",
br/web/package-lock.json: "resolved": "https://registry.npmjs.org/resolve/-/resolve-1.20.0.tgz",
build/image/base:ENV GOLANG_VERSION 1.20.6
go.sum:google.golang.org/grpc v1.20.1/go.mod h1:10oTOabMzJvdu6/UiuZezV6QK5dSlG84ov/aaiqXj38=
go.sum:google.golang.org/protobuf v1.20.1-0.20200309200217-e05f789c0967/go.mod h1:A+miEFZTKqfCUM6K7xSMQL9OKL/b6hQv+e19PK+JZNE=
parser/terror/terror_test.go: // /Users/pingcap/.gvm/gos/go1.20.1/src/testing/testing.go:1576
parser/terror/terror_test.go: // /Users/pingcap/.gvm/gos/go1.20.1/src/runtime/asm_arm64.s:1172
tests/globalkilltest/Dockerfile:ENV GOLANG_VERSION 1.20.5
tools/patch-go/Dockerfile:ENV GOLANG_VERSION 1.20.5
tools/patch-go/build.sh:GOVERS=1.20.5
@mjonss This has been a long-standing issue, and I'm thinking about how to consolidate it into one place. |
ti-chi-bot
bot
added
size/S
|
@mjonss I have been updated. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dveeden, mjonss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.