Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning test: remove tidb_enable_default_list_partition #45742

Closed
wants to merge 1 commit into from

Conversation

GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented Aug 2, 2023

What problem does this PR solve?

Issue Number: ref #45700

Problem Summary:

What is changed and how it works?

  • remove the variable in test

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 2, 2023
@tiprow
Copy link

tiprow bot commented Aug 2, 2023

Hi @GMHDBJD. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Aug 2, 2023

/run-br-integration-test

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #45742 (09ecb63) into master (1bf82bb) will increase coverage by 0.1115%.
Report is 10 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #45742        +/-   ##
================================================
+ Coverage   73.3396%   73.4511%   +0.1115%     
================================================
  Files          1271       1274         +3     
  Lines        392943     394300      +1357     
================================================
+ Hits         288183     289618      +1435     
+ Misses        86386      86326        -60     
+ Partials      18374      18356        -18     
Flag Coverage Δ
integration 78.1388% <ø> (?)
unit 73.4431% <ø> (+0.1034%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0359% <ø> (ø)
br 51.9661% <ø> (+0.0041%) ⬆️

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Aug 2, 2023

/run-pull-br-integration-test

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 2, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-02 02:02:43.522338012 +0000 UTC m=+237247.464686540: ☑️ agreed by hawkingrei.
  • 2023-08-02 03:45:54.546086664 +0000 UTC m=+243438.488435195: ☑️ agreed by lance6716.

@lance6716
Copy link
Contributor

/hold

wait the result of BR test

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2023
@lance6716
Copy link
Contributor

/test pull-br-integration-test

@tiprow
Copy link

tiprow bot commented Aug 2, 2023

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lance6716
Copy link
Contributor

tidb lightning encountered error: Get "https://https//127.0.0.1:2379/pd/api/v1/version": dial tcp: lookup https on 169.254.25.10:53: no such host

🤔

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Aug 2, 2023

tidb lightning encountered error: Get "https://https//127.0.0.1:2379/pd/api/v1/version": dial tcp: lookup https on 169.254.25.10:53: no such host

#45747

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Aug 3, 2023

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2023
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Aug 3, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 3, 2023

@GMHDBJD: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hawkingrei
Copy link
Member

/test pull-br-integration-test

@tiprow
Copy link

tiprow bot commented Aug 3, 2023

@hawkingrei: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, lance6716, lichunzhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,lance6716,lichunzhu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

lichunzhu added a commit to lichunzhu/tidb that referenced this pull request Aug 3, 2023
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Aug 3, 2023

/retest

@tiprow
Copy link

tiprow bot commented Aug 3, 2023

@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 3, 2023

@GMHDBJD: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-br-integration-test 09ecb63 link true /test pull-br-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GMHDBJD GMHDBJD closed this Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.3 release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants