planner: fix order-by grouping set expressions resolution may have already been resolved to grouping column already

[AilinKid]

What problem does this PR solve?

Issue Number: close #45715

Problem Summary:

What is changed and how it works?

order-by grouping set expressions resolution may have already been resolved to grouping column already
so when resolve the args of grouping function, the column/expression substitution is not always necessary

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

planner: fix order-by grouping set expressions resolution may have already been resolved to grouping column already

[tiprow]

Hi @AilinKid. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #45745 (95aca0e) into master (412fa13) will increase coverage by 0.0305%.
Report is 8 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #45745        +/-   ##
================================================
+ Coverage   73.3314%   73.3620%   +0.0305%     
================================================
  Files          1271       1274         +3     
  Lines        392954     393653       +699     
================================================
+ Hits         288159     288792       +633     
- Misses        86415      86462        +47     
- Partials      18380      18399        +19     

Flag	Coverage Δ
integration	78.1388% <ø> (?)
unit	73.3538% <100.0000%> (+0.0223%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	54.0444% <ø> (ø)
parser	85.0359% <ø> (-0.0109%)	⬇️
br	52.0255% <ø> (+0.0271%)	⬆️

[elsa0520]

LGTM

[AilinKid]

/test unit-test

[tiprow]

@AilinKid: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2023-08-02 08:47:47.034926722 +0000 UTC m=+261550.977275250: ☑️ agreed by elsa0520.
• 2023-08-03 03:50:33.829423725 +0000 UTC m=+330117.771772254: ☑️ agreed by guo-shaoge.

[AilinKid]

/test check_dev_2

[ti-chi-bot]

@AilinKid: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test build
• /test canary-scan-security
• /test check-dev
• /test check-dev2
• /test mysql-test
• /test pingcap/tidb/canary_ghpr_unit_test
• /test pull-br-integration-test
• /test pull-common-test
• /test pull-e2e-test
• /test pull-integration-common-test
• /test pull-integration-copr-test
• /test pull-integration-ddl-test
• /test pull-integration-jdbc-test
• /test pull-integration-mysql-test
• /test pull-mysql-connector-test
• /test pull-sqllogic-test
• /test pull-tiflash-test
• /test unit-test

The following commands are available to trigger optional jobs:

• /test pull-notify-when-compatibility-sections-changed

Use /test all to run the following jobs that were automatically triggered:

• pingcap/tidb/ghpr_build
• pingcap/tidb/ghpr_check
• pingcap/tidb/ghpr_check2
• pingcap/tidb/ghpr_mysql_test
• pingcap/tidb/ghpr_unit_test

In response to this:

/test check_dev_2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[AilinKid]

/test check-dev2

[tiprow]

@AilinKid: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check_dev_2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tiprow]

@AilinKid: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[AilinKid]

/test check-dev2

[tiprow]

@AilinKid: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[AilinKid]

/ok-to-test

[AilinKid]

/approve

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, elsa0520, guo-shaoge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [AilinKid,guo-shaoge]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment