Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indexmergereadtest: improve test performance #45781

Merged
merged 2 commits into from Aug 3, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Aug 3, 2023

What problem does this PR solve?

Issue Number: close #45782

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Aug 3, 2023
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #45781 (6e52455) into master (ef37474) will increase coverage by 0.0072%.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #45781        +/-   ##
================================================
+ Coverage   73.3503%   73.3575%   +0.0072%     
================================================
  Files          1271       1274         +3     
  Lines        392969     393646       +677     
================================================
+ Hits         288244     288769       +525     
- Misses        86349      86467       +118     
- Partials      18376      18410        +34     
Flag Coverage Δ
integration 78.1388% <ø> (?)
unit 73.3493% <ø> (-0.0011%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0359% <ø> (ø)
br 52.0255% <ø> (ø)

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 3, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-03 05:59:22.415989988 +0000 UTC m=+337846.358338519: ☑️ agreed by lance6716.
  • 2023-08-03 06:37:22.354292948 +0000 UTC m=+340126.296641478: ☑️ agreed by Defined2014.

@Defined2014
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2023
@Defined2014
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2023
@ti-chi-bot ti-chi-bot bot merged commit 6b9d303 into pingcap:master Aug 3, 2023
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestIndexMergeProcessWorkerHang takes too long
3 participants