Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: update code coverage for integration test #45852

Merged
merged 4 commits into from Aug 9, 2023

Conversation

3pointer
Copy link
Contributor

@3pointer 3pointer commented Aug 7, 2023

What problem does this PR solve?

Problem Summary:
update integration test coverage for br/lightining.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 7, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 7, 2023
@3pointer
Copy link
Contributor Author

3pointer commented Aug 7, 2023

/test pull-br-integration-test

@tiprow
Copy link

tiprow bot commented Aug 7, 2023

Hi @3pointer. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiprow
Copy link

tiprow bot commented Aug 7, 2023

@3pointer: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@3pointer
Copy link
Contributor Author

3pointer commented Aug 7, 2023

/test pull-br-integration-test

@tiprow
Copy link

tiprow bot commented Aug 7, 2023

@3pointer: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@3pointer
Copy link
Contributor Author

3pointer commented Aug 7, 2023

/test pull-br-integration-test

@tiprow
Copy link

tiprow bot commented Aug 7, 2023

@3pointer: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #45852 (4932d40) into master (6ad49e7) will increase coverage by 0.0827%.
Report is 29 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #45852        +/-   ##
================================================
+ Coverage   73.3543%   73.4371%   +0.0827%     
================================================
  Files          1272       1280         +8     
  Lines        393074     394212      +1138     
================================================
+ Hits         288337     289498      +1161     
+ Misses        86355      86317        -38     
- Partials      18382      18397        +15     
Flag Coverage Δ
integration 78.1388% <ø> (?)
unit 73.4290% <ø> (+0.0746%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.6758% <ø> (+0.6398%) ⬆️
br 52.0790% <ø> (+0.0366%) ⬆️

@3pointer 3pointer marked this pull request as ready for review August 8, 2023 10:25
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 8, 2023
@3pointer
Copy link
Contributor Author

3pointer commented Aug 9, 2023

/test pull-br-integration-test

@tiprow
Copy link

tiprow bot commented Aug 9, 2023

@3pointer: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@3pointer
Copy link
Contributor Author

3pointer commented Aug 9, 2023

/test pull-br-integration-test

@tiprow
Copy link

tiprow bot commented Aug 9, 2023

@3pointer: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@3pointer
Copy link
Contributor Author

3pointer commented Aug 9, 2023

/test pull-br-integration-test

@tiprow
Copy link

tiprow bot commented Aug 9, 2023

@3pointer: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leavrth, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 9, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-09 06:33:03.085783498 +0000 UTC m=+94347.634799485: ☑️ agreed by YuJuncen.
  • 2023-08-09 06:40:55.334319321 +0000 UTC m=+94819.883335308: ☑️ agreed by Leavrth.

@ti-chi-bot ti-chi-bot bot merged commit d8d81eb into pingcap:master Aug 9, 2023
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-issue-check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants