Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: add coverage report for explaintest #45930

Merged
merged 1 commit into from Aug 9, 2023

Conversation

Defined2014
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #44301

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none needs-cherry-pick-release-7.1 size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 9, 2023
@tiprow
Copy link

tiprow bot commented Aug 9, 2023

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Defined2014 Defined2014 changed the title Makefile: add report coverage for explaintest Makefile: add coverage report for explaintest Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #45930 (d0fd181) into master (0ac1bd7) will increase coverage by 0.0034%.
Report is 6 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #45930        +/-   ##
================================================
+ Coverage   73.3547%   73.3582%   +0.0034%     
================================================
  Files          1277       1280         +3     
  Lines        393395     394069       +674     
================================================
+ Hits         288574     289082       +508     
- Misses        86415      86547       +132     
- Partials      18406      18440        +34     
Flag Coverage Δ
integration 78.1388% <ø> (?)
unit 73.3499% <ø> (-0.0048%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0602% <ø> (+0.0243%) ⬆️
br 52.0312% <ø> (+0.0124%) ⬆️

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 9, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-09 05:40:08.877204844 +0000 UTC m=+91173.426220816: ☑️ agreed by xhebox.
  • 2023-08-09 06:32:32.777249171 +0000 UTC m=+94317.326265158: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot merged commit 1567bb0 into pingcap:master Aug 9, 2023
15 of 18 checks passed
@Defined2014 Defined2014 deleted the for-fun branch August 9, 2023 06:34
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #45931.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.1 release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants