Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: support serialization and deserialization of aggregate function for spill #46632

Merged
merged 84 commits into from
Nov 30, 2023
Merged

*: support serialization and deserialization of aggregate function for spill #46632

merged 84 commits into from
Nov 30, 2023

Conversation

xzhangxian1008
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 commented Sep 4, 2023 •
edited

What problem does this PR solve?

Issue Number: ref #47733

Problem Summary:

What is changed and how it works?

  • We add functions for AggFunc interface.
    • SerializeToChunkForSpill: Serialize PartialResult to a chunk
    • DeserializeToPartialResultForSpill: Deserialize chunk to PartialResult
    • serializeForSpill: serialize agg meta data to bytes
    • deserializeForSpill: deserialize bytes to add meta data

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 4, 2023
@tiprow
Copy link

tiprow bot commented Sep 4, 2023

Hi @xzhangxian1008. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xzhangxian1008
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 5, 2023
@xzhangxian1008
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 5, 2023
XuHuaiyu
XuHuaiyu reviewed Sep 6, 2023
View reviewed changes
executor/aggfuncs/spill_serialize_helper.go Outdated Show resolved Hide resolved
executor/aggfuncs/aggfuncs.go Outdated Show resolved Hide resolved
executor/aggfuncs/func_count_distinct.go Outdated Show resolved Hide resolved
XuHuaiyu
XuHuaiyu reviewed Sep 6, 2023
View reviewed changes
executor/aggfuncs/aggfuncs.go Outdated Show resolved Hide resolved
executor/aggfuncs/aggfuncs.go Outdated Show resolved Hide resolved
executor/aggfuncs/func_count.go Outdated Show resolved Hide resolved
executor/aggfuncs/spill_deserialize_helper.go Outdated Show resolved Hide resolved
XuHuaiyu
XuHuaiyu reviewed Sep 6, 2023
View reviewed changes
types/mydecimal.go Outdated Show resolved Hide resolved
XuHuaiyu
XuHuaiyu reviewed Sep 8, 2023
View reviewed changes
executor/aggfuncs/func_percentile.go Outdated Show resolved Hide resolved
executor/aggfuncs/func_sum.go Outdated Show resolved Hide resolved
executor/aggfuncs/aggfuncs.go Outdated Show resolved Hide resolved
executor/aggfuncs/aggfuncs.go Outdated Show resolved Hide resolved
executor/aggfuncs/spill_deserialize_helper.go Outdated Show resolved Hide resolved
executor/aggfuncs/spill_deserialize_helper.go Outdated Show resolved Hide resolved
XuHuaiyu
XuHuaiyu reviewed Sep 11, 2023
View reviewed changes
executor/aggfuncs/aggfuncs.go Outdated Show resolved Hide resolved
executor/aggfuncs/aggfuncs.go Outdated Show resolved Hide resolved
executor/aggfuncs/aggfuncs.go Outdated Show resolved Hide resolved
@xzhangxian1008
Copy link
Contributor Author

/cc @XuHuaiyu @windtalker

@ti-chi-bot ti-chi-bot bot requested a review from XuHuaiyu November 28, 2023 08:46
@xzhangxian1008
Copy link
Contributor Author

/cc @windtalker @XuHuaiyu

@ti-chi-bot ti-chi-bot bot requested a review from XuHuaiyu November 29, 2023 01:37
windtalker
windtalker approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 30, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [XuHuaiyu,windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 30, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-30 02:16:00.735382988 +0000 UTC m=+1061789.400609182: ☑️ agreed by XuHuaiyu.
  • 2023-11-30 08:28:33.842794865 +0000 UTC m=+1084142.508021060: ☑️ agreed by windtalker.

@ti-chi-bot ti-chi-bot bot merged commit 3ed4ba5 into pingcap:master Nov 30, 2023
14 of 15 checks passed
@xzhangxian1008 xzhangxian1008 deleted the improve-agg-for-spill branch November 30, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei left review comments

@windtalker windtalker windtalker approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xzhangxian1008 @windtalker @hawkingrei @XuHuaiyu