Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.github: update pull request template #46918

Merged
merged 4 commits into from
Sep 15, 2023
Merged

.github: update pull request template #46918

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bc68c4b
.github: update pull request template
wuhuizuo Sep 12, 2023
20d29d5
Update .github/pull_request_template.md
wuhuizuo Sep 12, 2023
0bbb29b
Update .github/pull_request_template.md
wuhuizuo Sep 15, 2023
34f7e97
Update .github/pull_request_template.md
wuhuizuo Sep 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ Tests <!-- At least one of them must be included. -->
- [ ] Integration test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No code
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this?

Suggested change
- [ ] No code
- [ ] No need test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will change it to No need to test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@okJiang I updated, PTAL again.

wuhuizuo marked this conversation as resolved.
Show resolved Hide resolved
> - [ ] I checked and no code files have been changed.
wuhuizuo marked this conversation as resolved.
Show resolved Hide resolved
> <!-- Or your custom "No code" reasons -->
wuhuizuo marked this conversation as resolved.
Show resolved Hide resolved

Side effects

Expand Down