New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ranger: split detach process from BuildRange. #4741

Merged
merged 4 commits into from Oct 12, 2017

Conversation

Projects
4 participants
@winoros
Member

winoros commented Oct 10, 2017

BuildRange is used when calculate range for scan plan and for selectivity. The detach process of this two situation won't be the same in the future, so split the detach process out of the BuildRange method.
PTAL @coocood @hanfei1991 @lamxTyler

eqCount int
)
for eqCount = 0; eqCount < len(accessCondition) && eqCount < len(cols); eqCount++ {
if sf, ok := accessCondition[eqCount].(*expression.ScalarFunction); !ok || sf.FuncName.L != ast.EQ {

This comment has been minimized.

@coocood

coocood Oct 12, 2017

Member

The original is inAndEqCount, now only Eq is counted.

@coocood

coocood Oct 12, 2017

Member

The original is inAndEqCount, now only Eq is counted.

This comment has been minimized.

@winoros

winoros Oct 12, 2017

Member

in has be rewritten to or. Currently there won't be any in function any more.

@winoros

winoros Oct 12, 2017

Member

in has be rewritten to or. Currently there won't be any in function any more.

@winoros winoros added the status/LGT1 label Oct 12, 2017

@winoros

This comment has been minimized.

Show comment
Hide comment
@winoros
Member

winoros commented Oct 12, 2017

PTAL @coocood

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Oct 12, 2017

Member

LGTM

Member

coocood commented Oct 12, 2017

LGTM

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Oct 12, 2017

Member

/run-all-test

Member

coocood commented Oct 12, 2017

/run-all-test

@shenli shenli merged commit 95a6e1e into master Oct 12, 2017

11 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 72.526%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@shenli shenli deleted the yiding/split branch Oct 12, 2017

@hanfei1991 hanfei1991 added this to Others in Planner Oct 17, 2017

@hanfei1991 hanfei1991 moved this from Others to ranger in Planner Oct 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment