Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning: fix lightning TLS.WithHost to access the correct host (#45749) #47734

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #45749

What problem does this PR solve?

Issue Number: close #45747

Problem Summary:

What is changed and how it works?

TrimPrefix before WithHost

Check List

Tests

  • Unit test

Side effects

  • None

Documentation

  • None

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@lichunzhu
Copy link
Contributor

/lgtm

2 similar comments
@lichunzhu
Copy link
Contributor

/lgtm

@lichunzhu
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 18, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-18 03:11:46.164971296 +0000 UTC m=+1799503.752081426: ☑️ agreed by lance6716.
  • 2023-10-18 03:13:56.195949881 +0000 UTC m=+1799633.783060011: ☑️ agreed by lichunzhu.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, lichunzhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lance6716,lichunzhu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, lichunzhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lance6716,lichunzhu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lance6716
Copy link
Contributor

/test pull-br-integration-test

@tiprow
Copy link

tiprow bot commented Oct 18, 2023

@lance6716: No presubmit jobs available for pingcap/tidb@release-7.1

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Oct 18, 2023
@lance6716
Copy link
Contributor

/hold

wait the lightning integration CI

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 18, 2023
@lance6716
Copy link
Contributor

/test pull-br-integration-test

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 18, 2023

@lance6716: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test unit-test

The following commands are available to trigger optional jobs:

  • /test pull-br-integration-test

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tidb/release-7.1/ghpr_build
  • pingcap/tidb/release-7.1/ghpr_check
  • pingcap/tidb/release-7.1/ghpr_check2
  • pingcap/tidb/release-7.1/ghpr_mysql_test
  • pingcap/tidb/release-7.1/ghpr_unit_test

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiprow
Copy link

tiprow bot commented Oct 18, 2023

@lance6716: No presubmit jobs available for pingcap/tidb@release-7.1

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lance6716
Copy link
Contributor

/test pull-br-integration-test

@tiprow
Copy link

tiprow bot commented Oct 18, 2023

@lance6716: No presubmit jobs available for pingcap/tidb@release-7.1

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-7.1@7a83625). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #47734   +/-   ##
================================================
  Coverage               ?   73.4358%           
================================================
  Files                  ?       1206           
  Lines                  ?     377524           
  Branches               ?          0           
================================================
  Hits                   ?     277238           
  Misses                 ?      82599           
  Partials               ?      17687           

@lance6716
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 18, 2023
@ti-chi-bot ti-chi-bot bot merged commit e5004d8 into pingcap:release-7.1 Oct 18, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants