Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importinto: fix data race in test #47965

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

D3Hunter
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #47776, #47941

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-7.5 release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 25, 2023
@tiprow
Copy link

tiprow bot commented Oct 25, 2023

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 25, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-25 07:32:32.570302455 +0000 UTC m=+2419950.157412598: ☑️ agreed by wjhuang2016.
  • 2023-10-25 07:45:57.232365423 +0000 UTC m=+2420754.819475567: ☑️ agreed by ywqzzy.

@D3Hunter
Copy link
Contributor Author

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, wjhuang2016, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #47965 (43a1334) into master (ecaa1c5) will increase coverage by 1.2971%.
Report is 5 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47965        +/-   ##
================================================
+ Coverage   71.7423%   73.0395%   +1.2971%     
================================================
  Files          1401       1424        +23     
  Lines        405664     414054      +8390     
================================================
+ Hits         291033     302423     +11390     
+ Misses        94892      92712      -2180     
+ Partials      19739      18919       -820     
Flag Coverage Δ
integration 42.4104% <0.0000%> (?)
unit 71.9857% <100.0000%> (+0.2433%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser ∅ <ø> (∅)
br 48.8570% <100.0000%> (-4.1707%) ⬇️

@D3Hunter
Copy link
Contributor Author

/retest

@tiprow
Copy link

tiprow bot commented Oct 25, 2023

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

/test all

@ywqzzy
Copy link
Contributor

ywqzzy commented Oct 26, 2023

/retest

@tiprow
Copy link

tiprow bot commented Oct 26, 2023

@ywqzzy: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit a7366f9 into pingcap:master Oct 26, 2023
21 of 36 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #47994.

@D3Hunter D3Hunter deleted the fix-flaky-cases branch October 26, 2023 02:23
ti-chi-bot bot pushed a commit that referenced this pull request Oct 26, 2023
yibin87 pushed a commit to yibin87/tidb that referenced this pull request Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Race detected for test TestLoadRemote/TestZStd
5 participants