Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disttask: optimize metrics #48663

Merged
merged 3 commits into from Nov 17, 2023
Merged

Conversation

okJiang
Copy link
Member

@okJiang okJiang commented Nov 17, 2023

What problem does this PR solve?

Issue Number: close #48592, #48591

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

img_v3_0259_d56e94fc-920b-44ff-b1b0-9d9bfd675adg

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

ti-chi-bot bot commented Nov 17, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added release-note-none needs-cherry-pick-release-7.5 do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 17, 2023
@okJiang okJiang marked this pull request as ready for review November 17, 2023 07:26
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 17, 2023
Copy link

tiprow bot commented Nov 17, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@okJiang
Copy link
Member Author

okJiang commented Nov 17, 2023

/ok-to-test

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #48663 (42f4fb3) into master (844ba42) will increase coverage by 1.5357%.
The diff coverage is 0.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #48663        +/-   ##
================================================
+ Coverage   71.0836%   72.6193%   +1.5357%     
================================================
  Files          1365       1389        +24     
  Lines        404263     411353      +7090     
================================================
+ Hits         287365     298722     +11357     
+ Misses        96945      93704      -3241     
+ Partials      19953      18927      -1026     
Flag Coverage Δ
integration 43.4974% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9874% <ø> (ø)
parser ∅ <ø> (∅)
br 48.7739% <ø> (-4.3090%) ⬇️

Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Nov 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Nov 17, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-17 14:45:42.236221121 +0000 UTC m=+4433139.823331259: ☑️ agreed by Benjamin2037.
  • 2023-11-17 14:59:26.62499321 +0000 UTC m=+4433964.212103355: ☑️ agreed by wjhuang2016.

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2023
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2023
@okJiang
Copy link
Member Author

okJiang commented Nov 17, 2023

/retest

@ti-chi-bot ti-chi-bot bot merged commit 36cb29f into pingcap:master Nov 17, 2023
15 of 16 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #48689.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 17, 2023
@okJiang okJiang deleted the dist-metrics-optimize branch November 18, 2023 01:58
ti-chi-bot bot pushed a commit that referenced this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 ok-to-test release-note-none size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metrics of dist execute framework should be more clear and concise
4 participants