New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store/tikv: fix a check visibility bug. #4867

Merged
merged 1 commit into from Oct 23, 2017

Conversation

Projects
None yet
3 participants
@disksing
Member

disksing commented Oct 23, 2017

When tikv returns empty response, it escapes from the visibility check.

@disksing disksing requested review from shenli, tiancaiamao and atmzhou Oct 23, 2017

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Oct 23, 2017

Member

LGTM

Member

shenli commented Oct 23, 2017

LGTM

@nolouch

This comment has been minimized.

Show comment
Hide comment
@nolouch

nolouch Oct 23, 2017

Member

LGTM

Member

nolouch commented Oct 23, 2017

LGTM

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Oct 23, 2017

Member

/run-all-tests

Member

shenli commented Oct 23, 2017

/run-all-tests

@shenli

shenli approved these changes Oct 23, 2017

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Oct 23, 2017

Member

Please cherry-pick this to release-1.0.

Member

shenli commented Oct 23, 2017

Please cherry-pick this to release-1.0.

@shenli shenli merged commit ae93e2b into pingcap:master Oct 23, 2017

12 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 72.508%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@disksing disksing deleted the disksing:safepoint branch Oct 23, 2017

disksing added a commit to disksing/tidb that referenced this pull request Oct 23, 2017

shenli added a commit to shenli/tidb that referenced this pull request Oct 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment