New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry for dialPumpClient #4879

Merged
merged 6 commits into from Oct 24, 2017

Conversation

Projects
None yet
5 participants
@XuHuaiyu
Contributor

XuHuaiyu commented Oct 24, 2017

fix #4848
PTAL @coocood

Show outdated Hide outdated tidb.go

@XuHuaiyu XuHuaiyu changed the title from 1. Add retry for dialPumpClient 2. make start TiDB server and connecting to binlog and pd simultaneous to Add retry for dialPumpClient Oct 24, 2017

Show outdated Hide outdated tidb_test.go
@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Oct 24, 2017

Member

Please fix CI and conflict

Member

coocood commented Oct 24, 2017

Please fix CI and conflict

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Oct 24, 2017

Contributor

PTAL @coocood

Contributor

XuHuaiyu commented Oct 24, 2017

PTAL @coocood

@coocood

This comment has been minimized.

Show comment
Hide comment
@coocood

coocood Oct 24, 2017

Member

LGTM

Member

coocood commented Oct 24, 2017

LGTM

@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu

XuHuaiyu Oct 24, 2017

Contributor

PTAL @shenli

Contributor

XuHuaiyu commented Oct 24, 2017

PTAL @shenli

Show outdated Hide outdated tidb_test.go
@@ -248,13 +247,30 @@ func newStoreWithRetry(path string, maxRetries int) (kv.Storage, error) {
}
var s kv.Storage
err1 := util.RunWithRetry(maxRetries, retryInterval, func() (bool, error) {
err1 := util.RunWithRetry(maxRetries, util.RetryInterval, func() (bool, error) {
log.Infof("new store")

This comment has been minimized.

@shenli

shenli Oct 24, 2017

Member

Why we log this?

@shenli

shenli Oct 24, 2017

Member

Why we log this?

This comment has been minimized.

@XuHuaiyu

XuHuaiyu Oct 24, 2017

Contributor

For recording this process.

@XuHuaiyu

XuHuaiyu Oct 24, 2017

Contributor

For recording this process.

Show outdated Hide outdated tidb.go

XuHuaiyu added some commits Oct 24, 2017

Merge branch 'master' of https://github.com/pingcap/tidb into issue4848
�ý,�ý.�ý`�ý,�ý.�ý,�ý.:q!
@XuHuaiyu

This comment has been minimized.

Show comment
Hide comment
@XuHuaiyu
Contributor

XuHuaiyu commented Oct 24, 2017

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Oct 24, 2017

Member

LGTM

Member

shenli commented Oct 24, 2017

LGTM

@shenli

shenli approved these changes Oct 24, 2017

@shenli

This comment has been minimized.

Show comment
Hide comment
@shenli

shenli Oct 24, 2017

Member

/run-all-tests

Member

shenli commented Oct 24, 2017

/run-all-tests

@zimulala zimulala added status/LGT2 and removed status/LGT1 labels Oct 24, 2017

@shenli shenli merged commit 8c7a090 into pingcap:master Oct 24, 2017

12 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 72.366%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
jenkins-ci-tidb/common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-tidb/mybatis-test Jenkins job succeeded.
Details
jenkins-ci-tidb/sqllogic-test Jenkins job succeeded.
Details
jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

dbjoa added a commit to cloud-pi/tidb that referenced this pull request Oct 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment