Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util/rowcodec,tablecodec: remove stmtctx dependency from rowcodec and tablecodec #48816

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

YangKeao
Copy link
Member

What problem does this PR solve?

Issue Number: close #48751

Problem Summary:

Remove the dependency stmtctx dependency from rowcodec and tablecodec.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 22, 2023
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #48816 (677dd9f) into master (fcda2f8) will increase coverage by 1.4682%.
Report is 17 commits behind head on master.
The diff coverage is 94.6236%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #48816        +/-   ##
================================================
+ Coverage   71.0900%   72.5583%   +1.4682%     
================================================
  Files          1367       1391        +24     
  Lines        404608     412063      +7455     
================================================
+ Hits         287636     298986     +11350     
+ Misses        97012      94175      -2837     
+ Partials      19960      18902      -1058     
Flag Coverage Δ
integration 43.5958% <73.1182%> (?)
unit 71.0162% <94.6236%> (-0.0738%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.8491% <ø> (-0.1173%) ⬇️
parser ∅ <ø> (∅)
br 48.6024% <ø> (-4.4215%) ⬇️

@YangKeao
Copy link
Member Author

/retest

Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
Copy link
Collaborator

@lcwangchao lcwangchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

pkg/tablecodec/tablecodec.go Outdated Show resolved Hide resolved
@YangKeao
Copy link
Member Author

/retest

Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@YangKeao
Copy link
Member Author

/retest

Copy link

ti-chi-bot bot commented Nov 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcwangchao, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Nov 23, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-23 08:16:18.006797506 +0000 UTC m=+478606.672023702: ☑️ agreed by tangenta.
  • 2023-11-23 08:50:34.846415044 +0000 UTC m=+480663.511641383: ☑️ agreed by lcwangchao.

@ti-chi-bot ti-chi-bot bot merged commit 707f860 into pingcap:master Nov 23, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove stmtctx dependency from tablecodec and rowcodec
3 participants