Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: refactor some code of the binding package #48959

Merged
merged 7 commits into from
Nov 28, 2023

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Nov 28, 2023

What problem does this PR solve?

Issue Number: ref #48875

Problem Summary: planner: refactor some code of the binding package

What changed and how does it work?

  1. move code of auto-capture into a separate file;
  2. remove code of evolution, which is no GA and deprecated;

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 28, 2023
@qw4990 qw4990 added sig/planner SIG: Planner epic/sql-plan-management and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 28, 2023
Copy link

tiprow bot commented Nov 28, 2023

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 28, 2023
@qw4990
Copy link
Contributor Author

qw4990 commented Nov 28, 2023

/test unit-test

Copy link

tiprow bot commented Nov 28, 2023

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #48959 (4219a41) into master (46d4231) will increase coverage by 1.6851%.
Report is 6 commits behind head on master.
The diff coverage is 1.5873%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #48959        +/-   ##
================================================
+ Coverage   70.9881%   72.6733%   +1.6851%     
================================================
  Files          1368       1390        +22     
  Lines        404890     412513      +7623     
================================================
+ Hits         287424     299787     +12363     
+ Misses        97444      93838      -3606     
+ Partials      20022      18888      -1134     
Flag Coverage Δ
integration 44.1344% <1.5873%> (?)
unit 70.9830% <ø> (-0.0051%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 48.4510% <ø> (-4.6298%) ⬇️

@qw4990
Copy link
Contributor Author

qw4990 commented Nov 28, 2023

/test unit-test

Copy link

tiprow bot commented Nov 28, 2023

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Nov 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-28 09:39:10.28231881 +0000 UTC m=+915578.947544989: ☑️ agreed by AilinKid.
  • 2023-11-28 09:45:39.618964978 +0000 UTC m=+915968.284191174: ☑️ agreed by hawkingrei.

Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

ti-chi-bot bot commented Nov 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 28, 2023
@hawkingrei
Copy link
Member

/test all

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit 68271e9 into pingcap:master Nov 28, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved epic/sql-plan-management lgtm release-note-none sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants