Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: upgrade codecov #48988

Merged
merged 3 commits into from
Nov 30, 2023
Merged

*: upgrade codecov #48988

merged 3 commits into from
Nov 30, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Nov 29, 2023

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 29, 2023
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #48988 (a0699d2) into master (68271e9) will increase coverage by 1.4772%.
Report is 26 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #48988        +/-   ##
================================================
+ Coverage   70.9767%   72.4540%   +1.4772%     
================================================
  Files          1368       1391        +23     
  Lines        404407     413483      +9076     
================================================
+ Hits         287035     299585     +12550     
+ Misses        97376      94995      -2381     
+ Partials      19996      18903      -1093     
Flag Coverage Δ
integration 43.7363% <ø> (?)
unit 70.9767% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 48.3115% <ø> (-4.7142%) ⬇️

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hi-rustin, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Nov 30, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-30 09:03:11.58049196 +0000 UTC m=+1086220.245718152: ☑️ agreed by YangKeao.
  • 2023-11-30 09:49:41.704947301 +0000 UTC m=+1089010.370173497: ☑️ agreed by hi-rustin.

@ti-chi-bot ti-chi-bot bot merged commit 3f81c2e into pingcap:master Nov 30, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-issue-check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants