statistics: log the db name #49011
Merged
statistics: log the db name #49011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
size/S
|
Test locally: |
13 tasks
hi-rustin
commented
Nov 29, 2023
pkg/statistics/handle/ddl/ddl.go
Outdated
| @@ -125,9 +130,12 @@ func (h *ddlHandlerImpl) HandleDDLEvent(t *util.DDLEvent) error { | |||
| // Get the count and modify count of the partition. | |||
| stats := h.statsHandler.GetPartitionStats(globalTableInfo, def.ID) | |||
| if stats.Pseudo { | |||
| is := h.ctx.GetDomainInfoSchema().(infoschema.InfoSchema) | |||
There was a problem hiding this comment.
Usually, this won't happen, so putting the getting scheme operation inside the if statement is OK.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #49011 +/- ##
================================================
+ Coverage 70.9775% 72.4646% +1.4870%
================================================
Files 1368 1391 +23
Lines 404391 411693 +7302
================================================
+ Hits 287027 298332 +11305
+ Misses 97368 94539 -2829
+ Partials 19996 18822 -1174
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/retest |
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
|
Tested again: |
time-and-fate
approved these changes
Nov 29, 2023
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
qw4990
approved these changes
Nov 29, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qw4990, time-and-fate The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #48929 (comment)
Problem Summary:
What changed and how does it work?
Printed the DB name in the logs.
Because changing the interface would have a significant invasive impact, the ctx was attached to the DDL handler. Otherwise, not only all the tests but also the handle's flush operation would have to query the schema by themselves.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.