Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global sort: fix a bug and prepare large scale data to s3 #49024

Merged
merged 14 commits into from
Nov 30, 2023

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Nov 30, 2023

What problem does this PR solve?

Issue Number: ref #48952

Problem Summary:

What changed and how does it work?

  • Fix a bug that AllocBytesWithSliceLocation wrongly used internal members so after buffer.Reset it will not allocate enough blocks
  • Add TestPrepareLargeData which writes 1000 * 256MB data to the given storage. In furture PR we will use these data to check the performance of merge step and LoadIngestData
  • Remove a flaky test because if goroutine runs faster than file "a" goroutine it will panic due to nil dereference. And returning the first error is easy when use errorgroup.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.
    bench_test.go:872: write 236706779520 bytes in 6m13.613271699s, speed: 604.21 MB/s
    bench_test.go:890: total 1000 data files, first file size: 256.00 MB, last file size: 256.00 MB

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: lance6716 <lance6716@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 30, 2023
Copy link

tiprow bot commented Nov 30, 2023

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: lance6716 <lance6716@gmail.com>
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #49024 (4bd4dc2) into master (720ae4b) will increase coverage by 1.5094%.
Report is 9 commits behind head on master.
The diff coverage is 0.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49024        +/-   ##
================================================
+ Coverage   70.9895%   72.4990%   +1.5094%     
================================================
  Files          1368       1391        +23     
  Lines        404079     412687      +8608     
================================================
+ Hits         286854     299194     +12340     
+ Misses        97242      94614      -2628     
+ Partials      19983      18879      -1104     
Flag Coverage Δ
integration 43.6961% <0.0000%> (?)
unit 70.9887% <ø> (-0.0008%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 48.3541% <0.0000%> (-4.6282%) ⬇️

Signed-off-by: lance6716 <lance6716@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Nov 30, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-30 03:31:50.747567499 +0000 UTC m=+1066339.412793679: ☑️ agreed by D3Hunter.
  • 2023-11-30 06:47:53.129256722 +0000 UTC m=+1078101.794482916: ☑️ agreed by Benjamin2037.

Copy link

ti-chi-bot bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, D3Hunter, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 30, 2023
@lance6716
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Nov 30, 2023

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit f39e9bf into pingcap:master Nov 30, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants