statistics: move the previous auto-analyze selection into a func #49027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
size/M
hi-rustin
added
skip-issue-check
and removed
size/M
function Signed-off-by: hi-rustin <rustin.liu@gmail.com>
ti-chi-bot
bot
added
the
size/S
qw4990
approved these changes
Nov 30, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #49027 +/- ##
================================================
+ Coverage 70.9896% 72.4993% +1.5096%
================================================
Files 1368 1391 +23
Lines 404070 411347 +7277
================================================
+ Hits 286848 298224 +11376
+ Misses 97242 94305 -2937
+ Partials 19980 18818 -1162
Flags with carried forward coverage won't be shown. Click here to find out more.
|
hawkingrei
approved these changes
Nov 30, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: None
Problem Summary:
What changed and how does it work?
Before proceeding with the implementation of a new auto-analysis queue, we can first consolidate the existing logic into one function. This way, it will be easier to revert to the old method if necessary. We don't have to remove the old logic right away. Instead, we can use a deprecation and opt-in process to gradually introduce this change to users.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.