Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: fix wrong file names #49028

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

hi-rustin
Copy link
Member

@hi-rustin hi-rustin commented Nov 30, 2023

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What changed and how does it work?

I fixed some wrong file names.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 30, 2023
@hi-rustin hi-rustin added skip-issue-check and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 30, 2023
@hi-rustin hi-rustin added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/planner SIG: Planner component/statistics labels Nov 30, 2023
Copy link
Member Author

@hi-rustin hi-rustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔢 Self-check

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #49028 (7d3552d) into master (6ec3a10) will increase coverage by 1.4841%.
Report is 4 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49028        +/-   ##
================================================
+ Coverage   70.9895%   72.4736%   +1.4841%     
================================================
  Files          1368       1391        +23     
  Lines        404054     411311      +7257     
================================================
+ Hits         286836     298092     +11256     
+ Misses        97240      94398      -2842     
+ Partials      19978      18821      -1157     
Flag Coverage Δ
integration 43.8003% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 48.3087% <ø> (-4.6736%) ⬇️

@hawkingrei
Copy link
Member

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2023
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 30, 2023
@hi-rustin hi-rustin changed the title statistics: remove the unused func statistics: fix wrong file names Nov 30, 2023
Copy link

ti-chi-bot bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,time-and-fate]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Nov 30, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-30 04:48:48.179637187 +0000 UTC m=+1070956.844863581: ☑️ agreed by time-and-fate.
  • 2023-11-30 08:18:40.997756211 +0000 UTC m=+1083549.662982406: ☑️ agreed by hawkingrei.

@hawkingrei
Copy link
Member

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2023
@ti-chi-bot ti-chi-bot bot merged commit 6dcb074 into pingcap:master Nov 30, 2023
16 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #49052.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 30, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants