-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: remove cmd in the dockerignore #49035
Conversation
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #49035 +/- ##
================================================
+ Coverage 70.9930% 72.5190% +1.5259%
================================================
Files 1368 1391 +23
Lines 403986 410979 +6993
================================================
+ Hits 286802 298038 +11236
+ Misses 97214 94131 -3083
+ Partials 19970 18810 -1160
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xhebox, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-7.5 |
@hawkingrei: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #49037
Problem Summary:
What changed and how does it work?
Check List
Tests
success to run
make docker
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.