Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: remove cmd in the dockerignore #49035

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Nov 30, 2023

What problem does this PR solve?

Issue Number: close #49037

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

success to run make docker


image

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #49035 (c8a5c49) into master (27fc7ea) will increase coverage by 1.5259%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49035        +/-   ##
================================================
+ Coverage   70.9930%   72.5190%   +1.5259%     
================================================
  Files          1368       1391        +23     
  Lines        403986     410979      +6993     
================================================
+ Hits         286802     298038     +11236     
+ Misses        97214      94131      -3083     
+ Partials      19970      18810      -1160     
Flag Coverage Δ
integration 43.6928% <ø> (?)
unit 70.9930% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 48.3702% <ø> (-4.6121%) ⬇️

@hawkingrei
Copy link
Member Author

/retest

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Nov 30, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-30 07:33:30.341333111 +0000 UTC m=+1080839.006559293: ☑️ agreed by xhebox.
  • 2023-11-30 07:41:06.773798797 +0000 UTC m=+1081295.439024992: ☑️ agreed by YangKeao.

@ti-chi-bot ti-chi-bot bot merged commit fcb497e into pingcap:master Nov 30, 2023
16 checks passed
@hawkingrei hawkingrei deleted the remove_ignore_cmd branch November 30, 2023 09:02
@hawkingrei
Copy link
Member Author

/cherrypick release-7.5

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.5: #49069.

In response to this:

/cherrypick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot bot pushed a commit that referenced this pull request Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fail to build when to use make docker
4 participants