Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disttask: fix flaky multi task test #49040

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Conversation

ywqzzy
Copy link
Contributor

@ywqzzy ywqzzy commented Nov 30, 2023

What problem does this PR solve?

Issue Number: close #49039

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none do-not-merge/needs-tests-checked do-not-merge/needs-triage-completed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 30, 2023
Copy link

tiprow bot commented Nov 30, 2023

Hi @ywqzzy. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, okJiang, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Nov 30, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-30 07:43:16.000178936 +0000 UTC m=+1081424.665405153: ☑️ agreed by XuHuaiyu.
  • 2023-11-30 07:45:15.748782268 +0000 UTC m=+1081544.414008448: ☑️ agreed by lance6716.

@lance6716
Copy link
Contributor

/check-issue-triage-complete

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #49040 (43c1e87) into master (27fc7ea) will increase coverage by 1.5264%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49040        +/-   ##
================================================
+ Coverage   70.9930%   72.5195%   +1.5264%     
================================================
  Files          1368       1391        +23     
  Lines        403986     410979      +6993     
================================================
+ Hits         286802     298040     +11238     
+ Misses        97214      94130      -3084     
+ Partials      19970      18809      -1161     
Flag Coverage Δ
integration 43.6744% <ø> (?)
unit 70.9930% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 48.3702% <ø> (-4.6121%) ⬇️

@ti-chi-bot ti-chi-bot bot merged commit 5850546 into pingcap:master Nov 30, 2023
16 checks passed
guo-shaoge pushed a commit to guo-shaoge/tidb that referenced this pull request May 30, 2024
close pingcap#49039

(cherry picked from commit 5850546)

Co-authored-by: EasonBall <592838129@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky test TestMultiTasks
4 participants