Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: move global index related test to tests/integrationtest #49044

Merged
merged 6 commits into from
Nov 30, 2023

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Nov 30, 2023

What problem does this PR solve?

Issue Number: ref #45961

Problem Summary: After #48834, we could use session variable to control global index, which means we could move global index related tests to IT now.

Total moved test cases number is 19.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 30, 2023
Copy link

tiprow bot commented Nov 30, 2023

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Defined2014
Copy link
Contributor Author

/test mysql-test

Copy link

tiprow bot commented Nov 30, 2023

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #49044 (e04ca60) into master (6ec3a10) will increase coverage by 1.4867%.
Report is 9 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49044        +/-   ##
================================================
+ Coverage   70.9895%   72.4763%   +1.4867%     
================================================
  Files          1368       1391        +23     
  Lines        404054     411311      +7257     
================================================
+ Hits         286836     298103     +11267     
+ Misses        97240      94391      -2849     
+ Partials      19978      18817      -1161     
Flag Coverage Δ
integration 43.7725% <ø> (?)
unit 70.9895% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 48.3087% <ø> (-4.6736%) ⬇️

select * from point where id = 1;
--replace_regex /.*num_rpc.*/.*num_rpc.*/
explain analyze select * from point where id = 1;
unlock tables;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add a line here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link

ti-chi-bot bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Nov 30, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-30 09:09:47.431002872 +0000 UTC m=+1086616.096229062: ☑️ agreed by hawkingrei.
  • 2023-11-30 09:17:20.837078282 +0000 UTC m=+1087069.502304477: ☑️ agreed by zimulala.

@ti-chi-bot ti-chi-bot bot merged commit b7de124 into pingcap:master Nov 30, 2023
16 checks passed
@Defined2014 Defined2014 deleted the move-more-tests branch November 30, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants