Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global sort: bench merge step #49376

Merged
merged 3 commits into from Dec 12, 2023
Merged

Conversation

ywqzzy
Copy link
Contributor

@ywqzzy ywqzzy commented Dec 12, 2023

What problem does this PR solve?

Issue Number: ref #48952

Problem Summary:
Add bench for merge step:

  1. with ascending order kv
  2. with random kv

What changed and how does it work?

On gcs with 16c machine.

bench_test.go:951: merge speed for 1258292064 bytes in 18.53020444s, speed: 64.76 MB/s
bench_test.go:951: merge speed for 1258292064 bytes in 18.243174291s, speed: 65.78 MB/s

The speed is relative slow since we haven't support parallel upload for gcs.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 12, 2023
Copy link

tiprow bot commented Dec 12, 2023

Hi @ywqzzy. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Merging #49376 (c96d2ff) into master (cf23666) will increase coverage by 0.8352%.
Report is 10 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49376        +/-   ##
================================================
+ Coverage   71.0490%   71.8843%   +0.8352%     
================================================
  Files          1368       1411        +43     
  Lines        401711     414097     +12386     
================================================
+ Hits         285412     297671     +12259     
- Misses        96443      97622      +1179     
+ Partials      19856      18804      -1052     
Flag Coverage Δ
integration 43.6148% <ø> (?)
unit 71.0490% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 47.9211% <ø> (-4.9723%) ⬇️

Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Dec 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Dec 12, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-12 09:45:24.206625593 +0000 UTC m=+349415.243852520: ☑️ agreed by lance6716.
  • 2023-12-12 13:34:01.727586733 +0000 UTC m=+363132.764813655: ☑️ agreed by Benjamin2037.

Copy link

tiprow bot commented Dec 12, 2023

@ywqzzy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test c96d2ff link true /test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit 1b199c2 into pingcap:master Dec 12, 2023
23 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants