Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: skip some warning during restore system schemas #49385

Merged
merged 7 commits into from Dec 21, 2023

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Dec 12, 2023

What problem does this PR solve?

Issue Number: ref #46527 Close #49394

Problem Summary:
some errors can be skipped.

What changed and how does it work?

skip the error

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Dec 12, 2023
Copy link

tiprow bot commented Dec 12, 2023

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Leavrth
Copy link
Contributor Author

Leavrth commented Dec 12, 2023

/test pull-br-integration-test

Copy link

tiprow bot commented Dec 12, 2023

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Merging #49385 (f7e9f60) into master (ba55c98) will increase coverage by 2.0848%.
Report is 95 commits behind head on master.
The diff coverage is 78.5714%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49385        +/-   ##
================================================
+ Coverage   71.0537%   73.1385%   +2.0848%     
================================================
  Files          1368       1425        +57     
  Lines        401803     434549     +32746     
================================================
+ Hits         285496     317823     +32327     
- Misses        96449      96902       +453     
+ Partials      19858      19824        -34     
Flag Coverage Δ
integration 47.9844% <78.5714%> (?)
unit 71.0553% <ø> (+0.0015%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 57.0517% <78.5714%> (+4.0929%) ⬆️

Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 14, 2023
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
Copy link
Contributor Author

Leavrth commented Dec 14, 2023

/test pull-br-integration-test

Copy link

tiprow bot commented Dec 14, 2023

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
Copy link
Contributor Author

Leavrth commented Dec 14, 2023

/test pull-br-integration-test

Copy link

tiprow bot commented Dec 14, 2023

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Leavrth
Copy link
Contributor Author

Leavrth commented Dec 14, 2023

error during merging temporary tables into system tables, table: tidb_mdl_view: [BR:Common:ErrUnknown]failed to execute REPLACE INTO mysql.tidb_mdl_view(job_id,db_name,table_name,query,session_id,txnstart,sql_digests) SELECT job_id,db_name,table_name,query,session_id,txnstart,sql_digests FROM __tidb_br_temporary_mysql.tidb_mdl_view ;: replace into view tidb_mdl_view is not supported now

Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
Copy link
Contributor Author

Leavrth commented Dec 14, 2023

/test pull-br-integration-test

Copy link

tiprow bot commented Dec 14, 2023

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Leavrth
Copy link
Contributor Author

Leavrth commented Dec 14, 2023

/retest

Copy link

tiprow bot commented Dec 14, 2023

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
Copy link
Contributor Author

Leavrth commented Dec 15, 2023

/test pull-br-integration-test

Copy link

tiprow bot commented Dec 15, 2023

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Leavrth
Copy link
Contributor Author

Leavrth commented Dec 15, 2023

/retest

Copy link

tiprow bot commented Dec 15, 2023

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Leavrth
Copy link
Contributor Author

Leavrth commented Dec 18, 2023

/retest

Copy link

tiprow bot commented Dec 18, 2023

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Dec 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Dec 21, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-12 09:35:53.283276551 +0000 UTC m=+348844.320503462: ☑️ agreed by 3pointer.
  • 2023-12-21 05:29:14.353063482 +0000 UTC m=+1111645.390290409: ☑️ agreed by YuJuncen.

@ti-chi-bot ti-chi-bot bot merged commit d2f3f36 into pingcap:master Dec 21, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FLUSH PRIVILEGES need to be run manually when there is a filter but filter system table
3 participants